Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statement construction for mixed-scope rules #1671

Merged
merged 12 commits into from
Aug 1, 2023
Merged

Statement construction for mixed-scope rules #1671

merged 12 commits into from
Aug 1, 2023

Conversation

yelhamer
Copy link
Collaborator

@yelhamer yelhamer commented Jul 27, 2023 •
edited
Loading

I've made several assumptions in this PR that I've summarized in this issue: #1672 . If you disagree with any of the assumptions made, then please let me know!

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@yelhamer yelhamer added breaking-change introduces a breaking change that should be released in a major version gsoc Work related to Google Summer of Code project. dynamic related to dynamic analysis flavor labels Jul 27, 2023
@yelhamer yelhamer self-assigned this Jul 27, 2023
@yelhamer yelhamer mentioned this pull request Jul 27, 2023
Closed
@yelhamer yelhamer linked an issue Jul 27, 2023 that may be closed by this pull request
Dynamic: Statement construction for mixed-scope rules #1672
Closed
@yelhamer yelhamer linked an issue Jul 29, 2023 that may be closed by this pull request
statement construction for multi-scope rules #1643
Closed
williballenthin
williballenthin requested changes Aug 1, 2023
View reviewed changes
capa/helpers.py Outdated Show resolved Hide resolved
williballenthin
williballenthin approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@williballenthin williballenthin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@williballenthin williballenthin merged commit 6192467 into mandiant:dynamic-feature-extraction Aug 1, 2023
15 checks passed
@yelhamer yelhamer mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williballenthin williballenthin williballenthin approved these changes

Assignees

@yelhamer yelhamer

Labels
breaking-change introduces a breaking change that should be released in a major version dynamic related to dynamic analysis flavor gsoc Work related to Google Summer of Code project.
Projects
@yelhamer GSoC 2023
Status: done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic: Statement construction for mixed-scope rules statement construction for multi-scope rules
2 participants
@yelhamer @williballenthin